Skip to content

Conversation

djhi
Copy link

@djhi djhi commented Nov 24, 2015

I have been using my fork on a personal project with Redux and it's been working very well. I thought I should share too. Thanks a lot for this skeleton, working with Meteor is fun again :)

I'm going to keep this fork and make a Meteor/Redux boilerplate (goodbye ReactMeteorData)

  • Put all scripts in bin folder
  • Added a makefile to run all commands expect met
  • Added a default .eslintrc using air-bnb presets
  • Updated parts from master (core-js build)
  • Uses mocha and sinon-chai for tests
  • Added test coverage with es6 support as you can see here:
    coverage

@jptissot
Copy link

There seems to be a bug in your PR. trying to run make run-dev does not work.

You renamed the var config .. to var baseconfig on top of the file ~/webpack/webpack.config.dev.js but you didn't update the rest of the file properly.

Here is the fixed version :

/* eslint no-var:0 */
var webpack = require('webpack');
var baseconfig = require('./webpack.config.client');
var _ = require('lodash');
var devProps = require('./devProps');
var RunInMeteorPlugin = require('webpack-meteor-tools/lib/RunInMeteorPlugin');
var dirs = require('../bin/dirs');

module.exports = _.assign(_.clone(baseconfig), {
  devtool: 'eval',
  entry: [
    'webpack-dev-server/client?' + devProps.baseUrl,
    'webpack/hot/only-dev-server',
  ].concat(baseconfig.entry),
  output: _.assign(_.clone(baseconfig.output), {
    publicPath: devProps.baseUrl + '/assets/',
    pathinfo: true,
  }),
  plugins: (baseconfig.plugins || []).concat([
    new webpack.HotModuleReplacementPlugin(),
    new webpack.NoErrorsPlugin(),
    new RunInMeteorPlugin({
      mode: 'development',
      target: 'client',
      meteor: dirs.meteor,
      key: 'client',
    }),
  ]),
  devServer: {
    publicPath: devProps.baseUrl + '/assets/',
    host: devProps.host,
    hot: true,
    historyApiFallback: true,
    contentBase: devProps.contentBase,
    port: devProps.webpackPort,
    // proxy: {
      // '/sockjs/*': {
      //   ws: true,
      //   target: 'ws://localhost:3000/sockjs',
      // },
      // '*': 'http://localhost:3000',
    // }
  },
});

@djhi
Copy link
Author

djhi commented Nov 26, 2015

Thx for noticing. I'll fix that

@jptissot
Copy link

Thanks for sharing this one btw. I was about to update the dependencies but saw you already did!

@djhi
Copy link
Author

djhi commented Nov 26, 2015

I'd like to share my current work on Meteor/Webpack/React/Redux. It's a kind of Trello like application for tracking your nutrition (what you eat every day). I'm building it for a friend nutritionist who want to use it for coaching. Any comments is welcome :) The app is in french but I plan to translate it very soon.

https://github.com/djhi/my-nutrition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants