Emit sourcemaps on client

[gabrielhpugliese]

This is needed to debug 👍 This is how it looks like now:

[jthomaschewski]

devTool 'source-map' does not have any cache. So it's very slow. Better use cheap-module-source-map or eval-source-map.

I think the reason why they use currently only simple eval source maps in this skeleton is that the huge redbox-react error plugin does not show correct line numbers and filenames when not using eval.
eval is the fastes and source maps are readable (but line numbers are wrong caused by babel transpiling).

You could try my PR #96 - I enabled cheap sourcemaps and fixed some hot reloading issues by using webpack-dev-server for everything, not only assets

+1 for good source maps even if this means to say good bye to huge red error messages

[gabrielhpugliese]

Cool 👍 Gonna try it.

[jthomaschewski]

That doesn't mean that you have to delete your PR.
I'm not the owner of this project so I can't decide anything :)

I would prefer a update of this PR using a better source map setting and maybe removal of the redbox-react plugin.
But jedwards1211 has to decided if he also prefers good source maps over this red error.

May be it's even possible to get both - For me the best solution was to just omit this redbox instead of trying to figure out how to fix this.

[gabrielhpugliese]

I closed because I didn't know that it did not cache the sourcemap and your PR is way more complete work :)

[gabrielhpugliese]

BTW, the redbox-react plugin is not showing the correct line for me even with eval.

[jthomaschewski]

Yes but at least it shows the correct file.
If I switch to any of the other source map methods I only get 'client.bundle' references or nothing at all.
Without redbox plugin filename and line numbers are correct in the dev console.

[gabrielhpugliese]

Seems reasonable to remove it then.

On Sun, Oct 11, 2015, 1:39 PM jbbr [email protected] wrote:

Yes but at least it shows the correct file.
If I switch to any of the other source map methods I only get
'client.bundle' references or nothing at all.
Without redbox plugin filename and line numbers are correct in the dev
console.

—
Reply to this email directly or view it on GitHub
#95 (comment)
.