Fix shared cmd::update value mutation breaking live chart updates - #3452
Open
Salvialf wants to merge 3 commits into
Open
Fix shared cmd::update value mutation breaking live chart updates#3452Salvialf wants to merge 3 commits into
Salvialf wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eqLogic.configure.phpandplugin.template.js) mutated thevalueproperty of the sharedcmd::updateevent payload object in place, instead of using a local copy for their own HTML-sanitized display.jeedom.cmd.refreshValue,jeedom.history.graphUpdate, and any otheraddUpdateFunctioncallback registered for the same command), so the mutation leaked into all code reading the value afterward, silently turning a numeric value into a string.jeedom.history.graphUpdate) to receive a string instead of a number whenever a page or modal containing one of these table displays was open, breaking the chart's live rendering for that command.eqLogic.configure.php,plugin.template.js,cmd.action.slider.shutter.htmland two mobile templates with the convention used across nearly all dashboard widget templates ({{Date de valeur}}:before{{Date de collecte}}:, no space before the colon), and added the missing{{}}translation wrapper around those strings incmd.info.string.multiline.html(mobile), which had never been translatable.