fix(sms): sanitize incoming SMS display values - #30
Open
xkg38 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incoming SMS bodies and sender values are remotely controlled and are stored in the Message and Sender commands. These string values may later be rendered by Jeedom widgets using innerHTML, allowing unescaped markup to be interpreted in the session of the user displaying the widget.
This change applies secureXSS() before logging or storing these display values. The original SMS body remains unchanged for askResponse() and interaction matching, so existing SMS interaction behavior is preserved.
Suggested changelog entry
Sanitize incoming SMS message and sender values before storing and displaying them.
Related issues/external references
No related public issue.
Types of changes
PR checklist