Allow Redis Connection to be Injected #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
requested changes
Nov 3, 2019
allcentury
force-pushed
the
redis-inject
branch
from
3a26c63 to
372025d
Compare
See issue jekyll#188 for details. Prior to this change, pooled redis connections were hard to share across. Now you can inject your own redis connection into the intiailizer via the `redis_conn` parameter.
allcentury
force-pushed
the
redis-inject
branch
from
372025d to
bf82c5c
Compare
|
@ashmaroli friendly ping - does all look ok here? |
ashmaroli
approved these changes
Nov 15, 2019
|
Sorry. This had slipped out of my radar.. |
|
+1 for this |
lewispb
reviewed
Dec 6, 2019
| @@ -33,7 +36,7 @@ def initialize(options = {}) | |||
| raise NoRedisError | |||
| end | |||
|
|
|||
| @redis = Redis.new(options) | |||
| @redis = options.fetch(:redis_conn, Redis.new(options)) | |||
There was a problem hiding this comment.
Minor point but my preference for the argument name would just be redis.
Suggested change
| @redis = options.fetch(:redis_conn, Redis.new(options)) | |
| @redis = options.fetch(:redis, Redis.new(options)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #188 for details.
Prior to this change, pooled redis connections were hard to share across jobs.
Now you can inject your own redis connection into the intiailizer via
the
redis_connparameter.