Add chapter skipping support to exoplayer client #1533
Conversation
…in both landscape and portrait modes
Currently translated at 100.0% (105 of 105 strings) Translation: Jellyfin Android/Jellyfin Android Translate-URL: https://translate.jellyfin.org/projects/jellyfin-android/jellyfin-android/sl/
Currently translated at 100.0% (105 of 105 strings) Translation: Jellyfin Android/Jellyfin Android Translate-URL: https://translate.jellyfin.org/projects/jellyfin-android/jellyfin-android/sl/
Currently translated at 100.0% (4 of 4 strings) Translation: Jellyfin Android/Jellyfin Android Fastlane Translate-URL: https://translate.jellyfin.org/projects/jellyfin-android/jellyfin-android-fastlane/sl/
* Migrate to Room Gradle plugin > The plugin configures the project such that generated schemas (which are > an output of the compile tasks and are consumed for auto-migrations) are > correctly configured to have reproducible and cacheable builds. https://developer.android.com/jetpack/androidx/releases/room#gradle-plugin * Remove explicit configuration of room.incremental property Incremental annotation processing is enabled by default: https://developer.android.com/jetpack/androidx/releases/room#compiler-options --------- Co-authored-by: Maxr1998 <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update dependency org.jellyfin.sdk:jellyfin-core to v1.6.1 Fix build errors and add API authorization headers to exoplayer since the access token is no longer passed via URL for Android Auto. See jellyfin/jellyfin-sdk-kotlin#871 * Use SDK for authorization header string building * Use getItem in MediaSourceResolver * Don't send authorization header to origins other than jellyfin server * Fix detekt lint warnings
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1444) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…1546) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…in#1547) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…fin#1550) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ellyfin#1551) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Currently translated at 100.0% (125 of 125 strings) Translation: Jellyfin Android/Jellyfin Android Translate-URL: https://translate.jellyfin.org/projects/jellyfin-android/jellyfin-android/he_IL/
Currently translated at 100.0% (125 of 125 strings) Translation: Jellyfin Android/Jellyfin Android Translate-URL: https://translate.jellyfin.org/projects/jellyfin-android/jellyfin-android/he/
|
That is super weird because my emulator doesn't have that setting anymore. I checked it against my phone, and my phone has the setting, but the emulator does not. I think the mobile app just sees itself as the browser wrapper, since the server is also reporting it as chrome. I will look into the issue some more tomorrow, and see if I can get it to run, but I've never had that happen before |
|
Ok found the culprit, will fixed with #1643 :) |
…in both landscape and portrait modes
…in both landscape and portrait modes
…leanRed/jellyfin-android into feat/add-chapters-exoplayer
|
Rebased onto master, not entirely sure why GitHub is reporting so many file changes, checked with a PR in my forked repo and there it just showed the 12 I touched. Is there anyway to programmatically get the size attributes from a drawable? I just checked my changes from January and I still have some magic numbers floating around like the chapter marking width and height in here file that I'd like to be more explainable |
|
Looking at the git history, I messed this branch up quite hard doing the rebase, might be easiest to just switch to a new one and cherry-pick my changes, instead of trying to fix it here, but let me know how you want me to proceed |
I would assume that something went wrong during the rebase. Maybe rebased on an old state of |
|
I decided not to fight it and just made a new branch here #1646, sorry for the inconvenience, was the fastest way I could get it to not be the current abomination |
Changes
Added buttons to support chapter skipping in the exoplayer client. Buttons are only present if chapters actually exist on the file being played. Button behaviour was modeled on how the web client works (e.g. the 10s interval in which going back a chapter results in going to the previous chapter, instead of starting the current one at 0)
Images
(Ignore the video quality, it's trying to software decode AV1 on the emulator)
Extra comments
Fixes
#155