Fix pagination when no items are present #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowghost
approved these changes
Jun 29, 2023
crobibero
approved these changes
Jun 29, 2023
crobibero
added
the
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue when setting this up on a fresh Trakt account. If you have nothing in your history, when you make a request to a page that supports pagination, the
X-Pagination-Page-Countheader value is set to 0.Since the check for pagination only checked that the count was not equal to the current page, and we start on page 1, this condition is never satisfied, spamming thousands of requests until eventually hitting the rate limits and stopping.
This changes the check so that if the current page is less than the total page count, we can continue requesting new pages.