Redesign library navigation in experimental layout #6582
Conversation
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/apps/experimental/components/AppToolbar/userViews/UserViewNav.tsx
Outdated
Show resolved
Hide resolved
src/apps/experimental/components/AppToolbar/userViews/UserViewNav.tsx
Outdated
Show resolved
Hide resolved
src/apps/experimental/components/AppToolbar/userViews/UserViewNav.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
11f0cb7 to
ab5a72d
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
ab5a72d to
568ee6f
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
568ee6f to
56c6b19
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
56c6b19 to
f23fcd0
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
f23fcd0 to
96b3173
Compare
|
Nice, looks a lot better now. I know I'm being a bit pedantic here but the upper and bottom padding doesn't appear the same on firefox. Edit: I think it's a weird firefox thing, it looks fine on safari Firefox: But here is a better view, it's 5px top vs 4px bottom. Safari: Here it's nicely 4px by 4px shakes fist at firefox, this reminds me of the good old IE vs Phoenix vs Opera days. |
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
96b3173 to
e095b02
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
e095b02 to
30a129d
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
30a129d to
7df3142
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
05c72ad to
ac8593d
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
ac8593d to
b43d0a2
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
b43d0a2 to
d5cdf77
Compare
thornbill
force-pushed
the
no-more-drawer-redux-part-2
branch
from
d5cdf77 to
c5da93c
Compare
thornbill
added
enhancement
|
There was a problem hiding this comment.
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/apps/experimental/AppOverrides.scss: Language not supported
Comments suppressed due to low confidence (1)
src/apps/experimental/features/libraries/constants/libraryRoutes.ts:168
- Multiple views in the '/homevideos' route are marked as 'isDefault'. This could lead to ambiguity when determining the default view; consider ensuring only one default per route.
isDefault: true
|
I personally preferred the drop-down approach of yester-pull for switching between different libraries, especially considering the amount of libraries different users have may vary greatly and is done less frequently during navigation. I do however agree that the other section navigation options should be listed in full as done here. |
|
Been using it every now and then, it's a small step up from the current experimental IMHO. In do miss the 1 click to get to dashboard from the old experimental though. |
|
It definitely won't be the final design (our design lead is working on a full redesign). It's just meant to address the layout issues caused by the pinned sidebar in the meantime. 😉 |
thornbill
added
feature
Note
These changes only applies to the experimental layout
Changes
Library navigation has been moved to the header with the order following the user settings:
If there are too many views, then the remaining options go into a "More" drop down menu:
When viewing a library, the text for that button is highlighted. The library view options were moved to a drop down menu replacing tabs and the alignment of the pagination and view options were updated:
The primary objective for this was to reduce the amount of space wasted by the pinned sidebar in the experimental layout that causes a lot of layout issues on smaller screens.
The mobile header is unchanged.
Issues
N/A