Skip to content

Add a file that contains all the labels a default project should have #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
halkeye wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a file that contains all the labels a default project should have #27

halkeye wants to merge 3 commits into from

Conversation

@halkeye
Copy link
Member

@halkeye halkeye commented Dec 19, 2019

No description provided.

@halkeye halkeye mentioned this pull request Dec 20, 2019
Closed
oleg-nenashev
oleg-nenashev requested changes Dec 24, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it under .github if the location does not matter.
Some documentation would be also nice.

@halkeye
Copy link
Member Author

halkeye commented Dec 25, 2019

I didn't want it to ever break something github would actually do.

Moved to .github

It was mostly for jenkins-infra/ircbot#72

Where good for docs, README in this repo?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Dec 25, 2019

If you are afraid of breaking someting by using .github, maybe we could create a new folder like github-templates or so. IMHO it makes sense to have a separate page for labels, similar to how release drafter is documented

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Feb 7, 2020

@halkeye Hi, are you still interested in it?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Feb 7, 2020

I believe the only question is whee to put it.
github-templates could be a good option, I am about doing the same for CODEOWNERS and dependabot

@halkeye
Copy link
Member Author

halkeye commented Feb 7, 2020

Yea, though have gotten no feedback on the ircbot side. I can move things super easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@halkeye @oleg-nenashev