Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75187] Unable to Connect to Agents #1041

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jmdesprez
Copy link
Contributor

Fix for https://issues.jenkins.io/browse/JENKINS-75187

Two fixes:

  • misplaced }
  • in the ServerKeyVerifier, convert the key to openSSH format

Testing done

Tested locally with:

  • an empty init script
  • all possible "Host Key Verification Strategy"

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jmdesprez jmdesprez marked this pull request as ready for review January 30, 2025 12:12
Copy link

@PereBueno PereBueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PereBueno
Copy link

@res0nance as per @jmdesprez comment, this fixes the bug introduced in https://github.com/jenkinsci/ec2-plugin/releases/tag/1822.v87175d209b_b_5
Could you review it?

Copy link

@pankajy-dev pankajy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@res0nance res0nance merged commit 828850f into jenkinsci:master Jan 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants