[JENKINS-74131] Extract inline JavaScript in FolderAuthorizationStrategyManagementLink/index.jelly#105
Open
yaroslavafenkin wants to merge 1 commit intojenkinsci:masterfrom
Open
Conversation
…tegyManagementLink/index.jelly`
yaroslavafenkin
commented
Dec 20, 2024
| * Adds a global role | ||
| */ | ||
| const addGlobalRole = () => { | ||
| function addGlobalRole() { |
Author
There was a problem hiding this comment.
Changing the way function is declared allows me to call these the way I do on line 128 of this file (https://github.com/jenkinsci/folder-auth-plugin/pull/105/files#diff-acf15339083ce65e46e34d649d67bf58880b907daaddcb899dd15454fef2a978R128).
Otherwise I'd have had to add a specific class to every element that needs a handler (global, folder, agent) and attach each event handler separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-74131
Along with CSP work I've also removed the calls to
getValue(), which I assume could be leftovers from some framework that was removed.Testing done
Before the change
After the change
Submitter checklist