Skip to content

[JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2025
Merged

[JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options #888

merged 4 commits into from
Sep 4, 2025

Conversation

jeromepochat
Copy link
Contributor

@jeromepochat jeromepochat commented Sep 4, 2025 •
edited
Loading

Description

This aims to clarify the limitations of the GitHub App Credentials new options and add backward compatibility notes.

See JENKINS-76056 for further information.

Note

The release note for 1844.v4a_9883d49126 will be updated with a link to the documentation after merge.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@jeromepochat jeromepochat requested a review from a team as a code owner September 4, 2025 12:03
@jeromepochat jeromepochat changed the title Clarify limitations and backwards compatibility [JENKINS-76056] Clarify limitations and backwards compatibility Sep 4, 2025
@jeromepochat jeromepochat changed the title [JENKINS-76056] Clarify limitations and backwards compatibility [JENKINS-76056] Clarify limitations of GitHub App Credentials new options and backwards compatibility Sep 4, 2025
@jeromepochat jeromepochat changed the title [JENKINS-76056] Clarify limitations of GitHub App Credentials new options and backwards compatibility [JENKINS-76056] Clarify inference limitations of GitHub App Credentials new options Sep 4, 2025
dwnusbaum
dwnusbaum reviewed Sep 4, 2025
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, I added a few suggestions

jeromepochat and others added 3 commits September 4, 2025 16:32
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
e7f6a6a 
Co-authored-by: Devin Nusbaum <[email protected]>
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
1bfe753 
Co-authored-by: Devin Nusbaum <[email protected]>
@jeromepochat @dwnusbaum
Update docs/github-app.adoc
ae4b2d3 
Co-authored-by: Devin Nusbaum <[email protected]>
@jeromepochat jeromepochat merged commit e66cbb9 into jenkinsci:master Sep 4, 2025
17 checks passed
@jeromepochat jeromepochat deleted the JENKINS-76056-doc-improvement branch September 4, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromepochat @dwnusbaum