Skip to content

Conversation

@daniel-beck
Copy link
Member

Description

This ensures GitHub org avatar images (the "folder icon") work in forthcoming Jenkins core releases when CSP protection is enforced.

See JENKINS-76302 for further information.

To manually test, create a GH organization folder and the icon needs to work while CSP is enforced (see core PR).

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scherler was working on something related in branch-source-plugin, I doubt they'll interfere but making a friendly ping anyway.

@daniel-beck daniel-beck marked this pull request as ready for review November 25, 2025 15:26
@daniel-beck daniel-beck requested a review from a team as a code owner November 25, 2025 15:26
@jglick jglick added bug and removed maintenance labels Nov 25, 2025
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really understand the security implications but presumably you do.

Just some technical requests here.

@jglick jglick merged commit 62fb7ff into master Nov 25, 2025
17 checks passed
@jglick jglick deleted the JENKINS-76302 branch November 25, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants