-
Notifications
You must be signed in to change notification settings - Fork 385
[JENKINS-76302] Make GH org avatars work with CSP #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rsandell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scherler was working on something related in branch-source-plugin, I doubt they'll interfere but making a friendly ping anyway.
jglick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really understand the security implications but presumably you do.
Just some technical requests here.
Description
This ensures GitHub org avatar images (the "folder icon") work in forthcoming Jenkins core releases when CSP protection is enforced.
See JENKINS-76302 for further information.
To manually test, create a GH organization folder and the icon needs to work while CSP is enforced (see core PR).
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify