Skip to content

Conversation

@jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Sep 21, 2025

JENKINS-76091 Use gitlab4j 5.8.1 to fix SNAKE_CASE missing symbol

#121 (comment)

To work with Jackson 2.20 without migrating to Jersey 3

Testing done

mvn clean install

Verified failure in GitLab branch source without this change and confirmed that the failure does not happen when this change is used.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@MarkEWaite
Copy link
Contributor

I've replayed the build using virtual machine agents as a way to avoid issue 4807

@MarkEWaite
Copy link
Contributor

I tested with a locally built version. I confirmed that I can see the problem without this change and that the problem is fixed with this change. We can ask the issue submitters to test it further.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

I've posted instructions to each of the duplicate issues in hopes that the submitters will help test the change. The issues include:

MarkEWaite added a commit to MarkEWaite/repository-permissions-updater that referenced this pull request Sep 21, 2025
Needs permission from one of the existing maintainers:

* @baymac
* @surenpi
* @jetersen
* @jeffpearce
* @justinharringa

Pull request to be merged and released is:

* jenkinsci/gitlab-api-plugin#122

Adoption needs to happen quickly because we need a release of the GitLab
API plugin to resolve the issue caused by the Jackson 2.20.0 API update
of the SNAKE_CASE symbol.

Jenkins issue reports include:

* [JENKINS-76091](https://issues.jenkins.io/browse/JENKINS-76091)
* [JENKINS-76105](https://issues.jenkins.io/browse/JENKINS-76105)
* [JENKINS-76110](https://issues.jenkins.io/browse/JENKINS-76110)
* [JENKINS-76116](https://issues.jenkins.io/browse/JENKINS-76116)
* [JENKINS-76117](https://issues.jenkins.io/browse/JENKINS-76117)
* [JENKINS-76119](https://issues.jenkins.io/browse/JENKINS-76119)
* [JENKINS-76125](https://issues.jenkins.io/browse/JENKINS-76125)
@MarkEWaite MarkEWaite added the bug Something isn't working label Sep 21, 2025
@MarkEWaite MarkEWaite changed the title Use gitlab4j 5.8.1 [JENKINS-76019] Use gitlab4j 5.8.1 Sep 21, 2025
@MarkEWaite MarkEWaite changed the title [JENKINS-76019] Use gitlab4j 5.8.1 [JENKINS-76091] Use gitlab4j 5.8.1 Sep 21, 2025
@MarkEWaite MarkEWaite merged commit ef1de80 into jenkinsci:master Sep 21, 2025
16 checks passed
@jmini
Copy link
Contributor

jmini commented Sep 21, 2025

Thank you.

Any pointers on how/when this new release is included in the next release of the BOM?:

    <dependencies>
      <dependency>
        <groupId>io.jenkins.tools.bom</groupId>
        <artifactId>bom-${jenkins.baseline}.x</artifactId>
        <version>5054.v620b_5d2b_d5e6</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>

Source: https://github.com/jenkinsci/gitlab-branch-source-plugin/blob/090f23d3cc490f3cb35af30ec1c181e58fe0f165/pom.xml#L44-L54

For the jenkinsci/gitlab-branch-source-plugin the version of io.jenkins.plugins:gitlab-api is defined by this BOM.

@jonesbusy jonesbusy deleted the feature/5.8.1 branch September 21, 2025 12:49
@jonesbusy
Copy link
Contributor Author

Bom is released weekly. Version can be overriding like https://github.com/jenkinsci/gitlab-branch-source-plugin/pull/508/files

@MarkEWaite
Copy link
Contributor

Any pointers on how/when this new release is included in the next release of the BOM?:

Is there a specific concern that you have that should push us to release a new version of the BOM earlier than next Friday? Version override is easy to do if someone needs it (as noted by @jonesbusy ) and Jenkins runtime allows newer plugin versions to be installed and used without requiring a change to the plugin BOM.

@jmini
Copy link
Contributor

jmini commented Sep 21, 2025

Working with version override is OK for me as well.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants