Simplify styling for 'Search bar'

[janfaracik]

This PR updates and simplifies the styling for the search bar component, where rather than reinvent the wheel in terms of design we just inherit the design from the existing input and dropdown classes.

This results in a mild UI change for the search bar, but keeps it consistent with other inputs:

Before

After

I've also simplified results for the search bar, we now reuse the styling of the dropdown component rather than have our own unique style for search.

Testing done

• Tested command palette, regular search and plugin search
• Results appear as expected

Proposed changelog entries

• N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[krisstern]

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

[daniel-beck]

What does this change mean to existing implementations (at least azure-vm-agents) that have just the existing class? Do they now need to be adapted, is it wrong to use the previous class without the new class?

[janfaracik]

Good spot, in the case of azure-vm-agents it uses a combobox which already has a jenkins-input class attached. If there are cases (which AFAIK in public repos there aren't) then yeah they'll need the jenkins-input class adding.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!