Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename '[Jenkins]' in tab title to '- Jenkins' #10178

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 18, 2025

A hopefully small PR to rename [Jenkins] in the tab title to - Jenkins. Using a hyphen is more common across the web and feels a little more polished IMV compared to the square brackets.

Testing done

  • Pages feature '- Jenkins' in their tab title now

Proposed changelog entries

  • N/A

Proposed developer changelog entries

  • Rename '[Jenkins]' in tab title to '- Jenkins'

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@janfaracik janfaracik requested a review from a team January 18, 2025 17:33
@janfaracik janfaracik added web-ui The PR includes WebUI changes which may need special expertise skip-changelog Should not be shown in the changelog developer Changes which impact plugin developers needs-ath-build Needs to run through the full acceptance-test-harness suite needs-pct-build A run through of bom is needed labels Jan 18, 2025
@janfaracik janfaracik added ath-successful This PR has successfully passed the full acceptance-test-harness suite pct-successful This PR has successfully passed the full plugin-compatibility-test suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite needs-pct-build A run through of bom is needed labels Jan 19, 2025
@timja
Copy link
Member

timja commented Jan 19, 2025

jenkinsci/email-ext-plugin#579 needs releasing first

@timja timja added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Jan 19, 2025
@krisstern krisstern requested a review from a team January 23, 2025 11:55
@timja timja removed the on-hold This pull request depends on another event/release, and it cannot be merged right now label Jan 23, 2025
@timja
Copy link
Member

timja commented Jan 23, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 23, 2025
@krisstern krisstern merged commit 2183bca into jenkinsci:master Jan 24, 2025
16 checks passed
@janfaracik janfaracik deleted the rename-jenkins-in-tab-title branch January 24, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite developer Changes which impact plugin developers pct-successful This PR has successfully passed the full plugin-compatibility-test suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants