Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format 'admin' differently in the setup wizard for clarity #9194

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Member

Followup to #9185 (comment): Make it clearer, through formatting, that "admin" is a username and not just referring to an administrator account.

If tentatively accepted, will update localizations (where possible, when unclear will delete)

Testing done

Ran this to take screenshots:

Screenshot 2024-04-25 at 18 55 05 Screenshot 2024-04-25 at 18 52 51

Proposed changelog entries

Too minor

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck added the web-ui The PR includes WebUI changes which may need special expertise label Apr 25, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 25, 2024
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Apr 25, 2024

I tested it and confirmed it looks right. I confirmed that the extra '{}' pair is needed in the hbs file otherwise the HTML formatting is not rendered correctly. Thanks!

@MarkEWaite MarkEWaite self-assigned this Apr 25, 2024
@daniel-beck daniel-beck removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 26, 2024
@daniel-beck
Copy link
Member Author

Removing merge label per

If tentatively accepted, will update localizations (where possible, when unclear will delete)

@yaroslavafenkin yaroslavafenkin added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label May 7, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label May 18, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 11, 2024
@timja timja marked this pull request as draft June 17, 2024 15:28
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 26, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 26, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-approved @jenkinsci/core-security-review reviewed this PR for security issues unresolved-merge-conflict There is a merge conflict with the target branch. web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants