Prototype of rewrite of CLI
to not use Tyrus
#9688
Draft
+89
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amending #9591 and #9687. FTR
and now I see this too on Linux the first time I try.
I think this is a Tyrus bug. I actually saw the same NPE reproducibly with my initial attempt at a fix, calling
HandshakeResponse.getHeaders
from insideafterResponse
. I thought I had isolated the cause to capture of local variables from theConfigurator
but apparently it was something else, maybe a race condition. Probably makes sense to switch to the JDK’s client rather than waste more time on Tyrus; easy enough without TLS but would take a bit more work to testnoCertificateCheck
.Testing done
None so far beyond the one automated test.
Proposed changelog entries
Before the changes are marked as
ready-for-merge
:Maintainer checklist