Remove call to isDefaultWorkspaceDir

[MarkEWaite]

Remove call to isDefaultWorkspaceDir

Jenkins 2.584 removes the isDefaultWorkspaceDir method. This is the only reference found by GitHub search in all of jenkinsci.

Removed by pull request:

• Do not persist workspaceDir + buildsDir jenkins#27406

Detected by pull requests:

• Test master branch and a few pull requests jenkins#27453
• [WIP] Test 2.584 pre-release and a few pull requests bom#7496

Upgrades the parent pom because otherwise the plugin cannot be compiled with Jenkins 2.583

Needs to be merged and released before the next plugin BOM release, otherwise it will block the upgrade to Jenkins 2.584.

Testing done

• Confirmed compilation fails without this change:
  mvn -Djenkins.version=2.584-rc38753.cd27cb_2e2b_98 verify
• Confirmed compilation succeeds and test passes with this change:
  mvn -Djenkins.version=2.584-rc38753.cd27cb_2e2b_98 -Dtest=JenkinsBuildsAndWorkspacesDirectoriesTest verify

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[MarkEWaite]

This needs to be labeled developer and merged before the end of this week so that it won't block the plugin BOM from adopting Jenkins 2.584.

@Vlatombe or @olamy could you review, merge, and release this pull request?

@jglick if one of those two are not available, could you help persuade one of the other maintainers to review and merge it?

[jglick]

The last release was cut by Basil AFAICT, and there is no CD. Maybe @timja or someone else with org-wide powers is able to cut releases? Otherwise I guess you can exclude the test from the BOM, but in general if there is no one able or willing to release it then it should not be in the BOM any more.

[timja]

@olamy / @Vlatombe

[MarkEWaite]

I guess you can exclude the test from the BOM, but in general if there is no one able or willing to release it then it should not be in the BOM any more.

No worry. The maven plugin has been removed from the plugin BOM with pull request:

• Remove Maven plugin from plugin BOM bom#7513

The pull request can wait indefinitely.

[olamy]

I have deployed a 3.28 release.
Always fun to do this manually. It remembers me when I was a cool kid 🤣