-
Notifications
You must be signed in to change notification settings - Fork 247
Add pointer even when HDMI isn't feeding video #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Interesting idea! Note that we already have request full screen in the ActionBar but it (and Macros) are disabled when we're not fully connected... perhaps we should revise that to allow clicking the button even if HDMI is not running? |
Totally missed that. Seems simpler and cleaner from a UI perspective to do that, will take a look at modifying that. |
This reverts commit dc7791c.
|
So I really am blind, the Fullscreen button is visible even when HDMI is not running. So just reverted the second commit. |
adamshiervani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this in the next version, but the pointer and keyboard lock UX is really in need of some care.
My use case for my JetKVM is to control another computer on my desktop that has its own display, so I have no need for the video display. However, I do want to be able to enable Pointer Lock and Keyboard Lock.
This PR adds two UI features to provide this:
I accept any input on the UI, as I'm not a frontend dev. I had also implemented Pointer Lock and Fullscreen buttons in the Actionbar, but it's already a bit crowded. It might also be worth hiding this functionality behind an options toggle, but it mirrors similar behavior on PiKVM.