Skip to content

Conversation

@tomwopat
Copy link

@tomwopat tomwopat commented Sep 24, 2025

My use case for my JetKVM is to control another computer on my desktop that has its own display, so I have no need for the video display. However, I do want to be able to enable Pointer Lock and Keyboard Lock.

This PR adds two UI features to provide this:

  • It allows enabling Pointer Lock by clicking anywhere where the video display would be
  • It adds a Fullscreen button in the HDMI signal message. There is not currently a way with any browser to enable Keyboard Lock without entering fullscreen.

I accept any input on the UI, as I'm not a frontend dev. I had also implemented Pointer Lock and Fullscreen buttons in the Actionbar, but it's already a bit crowded. It might also be worth hiding this functionality behind an options toggle, but it mirrors similar behavior on PiKVM.

@IDisposable
Copy link
Contributor

Interesting idea! Note that we already have request full screen in the ActionBar but it (and Macros) are disabled when we're not fully connected... perhaps we should revise that to allow clicking the button even if HDMI is not running?

https://github.com/jetkvm/kvm/pull/822/files#diff-503edceb49a3a14452eb4663ab40040a5ff04a2a89f13e48be02539e2c939f08R488

@IDisposable IDisposable changed the title feat: Add feat: Add ability to go to Fullscreen and get pointer and keyboard lock even when HDMI isn't feeding video Sep 24, 2025
@tomwopat
Copy link
Author

Interesting idea! Note that we already have request full screen in the ActionBar but it (and Macros) are disabled when we're not fully connected... perhaps we should revise that to allow clicking the button even if HDMI is not running?

https://github.com/jetkvm/kvm/pull/822/files#diff-503edceb49a3a14452eb4663ab40040a5ff04a2a89f13e48be02539e2c939f08R488

Totally missed that. Seems simpler and cleaner from a UI perspective to do that, will take a look at modifying that.

@tomwopat
Copy link
Author

So I really am blind, the Fullscreen button is visible even when HDMI is not running. So just reverted the second commit.

Copy link
Contributor

@adamshiervani adamshiervani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this in the next version, but the pointer and keyboard lock UX is really in need of some care.

@adamshiervani adamshiervani changed the title feat: Add ability to go to Fullscreen and get pointer and keyboard lock even when HDMI isn't feeding video Add pointer even when HDMI isn't feeding video Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants