[VC-43753] CyberArk(client): add CyberArk snapshot conversion and test utilities #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallrj-cyberark
commented
Aug 9, 2025
| Resource interface{} | ||
| DeletedAt Time | ||
| Resource interface{} `json:"resource"` | ||
| DeletedAt Time `json:"deleted_at,omitempty"` | ||
| } |
There was a problem hiding this comment.
Added json annotations here so that I can unmarshal date readings from a file, for testing.
The agent already has an --input-file option, but stops decoding the input at api.DataReading.Data, leaving the actual data as interface{}.
In the test in this PR I need to decode the Data, so that it has the same types as the DataGatherer.Fetch return values.
pkg/datagatherer/k8s/discovery.go
Outdated
| type DiscoveryData struct { | ||
| ServerVersion *version.Info `json:"server_version"` | ||
| } | ||
|
|
There was a problem hiding this comment.
I created a data type instead of the ad-hoc map that was previously returned by this data gatherer,
to make it easier to do a type conversion in ConverDatareadingsToCyberarkSnapshot function.
inteon
reviewed
Aug 12, 2025
wallrj-cyberark
force-pushed
the
VC-43403-inventory-api-2
branch
2 times, most recently
from
9606752 to
4d8e691
Compare
wallrj-cyberark
changed the base branch from
master
to
VC-43403-inventory-api-sha3
wallrj-cyberark
force-pushed
the
VC-43403-inventory-api-2
branch
2 times, most recently
from
88c1cc7 to
8b9a233
Compare
wallrj-cyberark
force-pushed
the
VC-43403-inventory-api-2
branch
4 times, most recently
from
2d44e46 to
34d67da
Compare
inteon
reviewed
Aug 21, 2025
| - kind: k8s-discovery | ||
| name: ark/discovery | ||
| - kind: k8s-dynamic | ||
| name: ark/secrets |
There was a problem hiding this comment.
@wallrj-cyberark Since the name here is ark-specific, does that mean that we will fetch secrets twice (once for TLSPK and once for the Secret solution?)
wallrj-cyberark
force-pushed
the
VC-43403-inventory-api-2
branch
2 times, most recently
from
caadaf0 to
e8f50da
Compare
wallrj-cyberark
force-pushed
the
VC-43403-client
branch
6 times, most recently
from
78700c9 to
b7adba8
Compare
wallrj-cyberark
force-pushed
the
VC-43403-client
branch
4 times, most recently
from
a331e26 to
0bfb107
Compare
wallrj-cyberark
force-pushed
the
VC-43403-client
branch
4 times, most recently
from
ae1b4fb to
d82113d
Compare
- Introduced a new `MachineHub` output mode in the agent configuration. - Added `--machine-hub` flag to enable the `MachineHub` mode. - Implemented `CyberArkClient` for publishing data readings to CyberArk's API. - Created `LoadClientConfigFromEnvironment` to load CyberArk client configuration from environment variables. - Updated tests to cover `MachineHub` mode and CyberArk client functionality. - Modified mock data and discovery logic to support CyberArk integration. Signed-off-by: Richard Wall <[email protected]>
wallrj-cyberark
force-pushed
the
VC-43403-client
branch
from
d82113d to
8842333
Compare
- Introduced `ConvertDataReadingsToCyberarkSnapshot` to transform data readings into CyberArk snapshot format. - Enhanced `PostDataReadingsWithOptions` to utilize the new snapshot conversion. - Added `DynamicData` and `DiscoveryData` types for structured data handling. - Updated `DataGathererDynamic` and `DataGathererDiscovery` to return strongly typed data. - Implemented `ParseDataReadings` in `testutil` for decoding and testing data readings. - Added test data and golden file support for snapshot conversion validation. Signed-off-by: Richard Wall <[email protected]>
wallrj-cyberark
force-pushed
the
VC-43403-inventory-api-2
branch
from
e8f50da to
7686607
Compare
wallrj-cyberark
changed the title
wallrj-cyberark
force-pushed
the
VC-43403-client
branch
from
8842333 to
5a2ae3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #696
ConvertDataReadingsToCyberarkSnapshotto transform data readings into CyberArk snapshot format.PostDataReadingsWithOptionsto utilize the new snapshot conversion.DynamicDataandDiscoveryDatatypes for structured data handling.DataGathererDynamicandDataGathererDiscoveryto return strongly typed data.ParseDataReadingsintestutilfor decoding and testing data readings.The client still deviates from the API requirements, as follows:
...but I prefer to address those in followup PRs, as time permits.
Part of: https://venafi.atlassian.net/browse/VC-43753
Followup PRs
Testing
TODO