Improve the documentation for the Jetty Server Dump

documentation/jetty/modules/code/examples/src/main/java/org/eclipse/jetty/docs/programming/ComponentDocs.java

@@ -281,4 +281,21 @@ public void beanRemoved(Container parent, Object child)
         parent.addBean(younger);
         // end::containerSiblings[]
     }
+
+    public void dumpExample()
+    {
+        Server server = new Server();
+        // tag::dumpAfterStartExample[]
+        server.setDumpAfterStart(true);
+        server.setDumpBeforeStop(true);
+        // end::dumpAfterStartExample[]
+
+        // tag::dumpExample[]
+        // Get dump as a string.
+        String dumpString = server.dump();
+
+        // Or dump to standard error stream.
+        server.dumpStdErr();
+        // end::dumpExample[]
+    }
 }

documentation/jetty/modules/operations-guide/pages/troubleshooting/component-dump.adoc

@@ -0,0 +1,34 @@
+//
+// ========================================================================
+// Copyright (c) 1995 Mort Bay Consulting Pty Ltd and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// https://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+// which is available at https://www.apache.org/licenses/LICENSE-2.0.
+//
+// SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+// ========================================================================
+//
+
+[[dump]]
+= Jetty Component Dump
+
+The Jetty Server Dump is a useful tool for debugging the state of the server.
+See the xref:programming-guide:troubleshooting/component-dump.adoc[Jetty Server Dump] section for detailed information.
+
+[[dump-start-stop]]
+== Dump at Server Start/Stop
+
+The dump operation may also be invoked just after the `Server` starts (to log the state of the freshly started server), and just before the `Server` stops (which may be useful to log the state of server that is not working properly).
+
+Standalone Jetty uses two properties to control this behaviour which are referenced in `jetty.xml` to call these setters.
+These properties are `jetty.server.dumpAfterStart` and `jetty.server.dumpBeforeStop`.
+
+These can be temporarily enabled by supplying these properties as command line arguments,
+or to make this change persistent across server restarts they can be enabled via the `server.ini` file (see xref:operations-guide:modules/standard.adoc#server-config[Server Configuration]).
+
+[source,subs=+quotes]
+----
+$ java -jar $JETTY_HOME/start.jar *jetty.server.dumpAfterStart=true*
+----

documentation/jetty/modules/operations-guide/pages/troubleshooting/index.adoc

@@ -15,53 +15,15 @@
 
 To troubleshoot Jetty when used as a standalone server, there are two main tools: the Jetty Server Dump and enabling DEBUG level logging.
 
-Jetty is based on components organized as a tree, with the `Server` instance at the root of the tree.
-
-As explained in the xref:jmx/index.adoc[JMX section], these components can be exported as JMX MBeans and therefore be accessible from JMX Consoles such as Java Missions Control (JMC).
-
-Being able to take a snapshot of the state of Jetty while it is running is the most useful information that can be attached when reporting an issue.
-Such state includes:
-
-* The thread pool configuration and its current state, including how many threads are in use, and their stack trace.
-* The TLS configuration.
-* The I/O configuration and its current state, including the ports Jetty listens to, how many connections are currently open, and he state of each connection, and the state of the request/response handling for each connection.
-* The `Handler` structure and its configuration.
-* The web applications deployed and their configurations, including the class loader information.
-
-The prerequisite for troubleshooting is to enable JMX, so that Jetty -- possibly a production server -- can be accessed from a remote location to obtain the information exported via JMX, and possibly be able to reconfigure Jetty to solve the issue.
+For troubleshooting, it can be helpful to enable JMX, so that Jetty -- possibly a production server -- can be accessed from a remote location to obtain the information exported via JMX, and possibly be able to reconfigure Jetty to solve the issue.
 
 IMPORTANT: Make sure you read about how to secure the access to Jetty when using xref:jmx/index.adoc#remote[remote JMX].
 
 [[dump]]
-== Server Dump
-
-The Jetty Server Dump is obtained by invoking, via JMX, the `Server.dump()` operation, as shown below using https://adoptium.net/jmc.html[Java Mission Control (JMC)]:
-
-image::jmc-server-dump.png[]
-
-Find the `Server` MBean in the MBean Tree, under `org.eclipse.jetty.server:type=server,id=0`.
-Then click on the "Operations" tab, select the `dump()` operation, and then click the `Execute` button.
-In the bottom panel you will see the result of the invocation, that you can copy into a text editor and save to your file system.
-
-[CAUTION]
-====
-Taking a Jetty Server Dump is a relatively expensive operation, as it dumps the state of all connections (which can be thousands), and the state of all threads.
-
-The result of the invocation may produce a large string, possibly few MiB, that may impact the server memory usage.
-
-Furthermore, dumping the state of the I/O Jetty components takes a little CPU time off the handling of the actual I/O, possibly slowing it down temporarily.
-
-While the slow-down caused by taking the Jetty Server Dump may be noticeable on highly loaded systems, it is typically a very small price to pay to obtain the information about the Jetty state that may be critical to the resolution of an issue.
-====
-
-[NOTE]
-====
-The format of the Jetty Server Dump output is subject to change at any time, as Jetty developers modify the Jetty code and decide to include more state, or remove state that is no longer relevant.
-
-The Jetty Server Dump is organized in a tree whose structure is similar to the runtime Jetty component tree.
+== Jetty Component Dump
 
-At the end of the dump output there is a legend that explains the type of tree node: whether it is a node that represent a _managed_ component, or an _array_ node (or a _map_ node) that represent some component state, etc.
-====
+The Component Server Dump is a useful tool for debugging the state of the server.
+See the xref:programming-guide:troubleshooting/component-dump.adoc[Jetty Server Dump] section for detailed information.
 
 [[dump-start-stop]]
 === Dump at Server Start/Stop
@@ -70,47 +32,17 @@ The `Server.dump()` operation may also be invoked just after the `Server` starts
 
 You can temporarily enable the Jetty Server Dump at start time by overriding the `jetty.server.dumpAfterStart` property on the command line:
 
+Standalone Jetty uses two properties to control this behaviour which are referenced in `jetty.xml` to call these setters.
+These properties are `jetty.server.dumpAfterStart` and `jetty.server.dumpBeforeStop`.
+
+These can be temporarily enabled by supplying these properties as command line arguments,
+or to make this change persistent across server restarts they can be enabled via the `server.ini` file (see xref:operations-guide:modules/standard.adoc#server-config[Server Configuration]).
+
 [source,subs=+quotes]
 ----
 $ java -jar $JETTY_HOME/start.jar *jetty.server.dumpAfterStart=true*
 ----
 
-To make this change persistent across server restarts, see the xref:modules/standard.adoc#server[`server` module] configuration for more information about how to configure the server to dump at start/stop time.
-
-[[dump-detailed]]
-=== Detailed ThreadPool Information
-
-By default, the dump of the thread pool will only dump the topmost stack frame of each thread.
-It is possible to configure the thread pool to dump the whole stack trace for each thread; while this may be a little more expensive, it provides complete information about the state of each thread, which may be important to diagnose the issue.
-
-See the xref:modules/standard.adoc#threadpool[`threadpool` module] configuration for more information about how to configure the thread pool to dump detailed thread information.
-
-Detailed thread pool information can also be turned on/off on-the-fly via JMX, by finding the `ThreadPool` MBean under `org.eclipse.jetty.util.thread:type=queuedthreadpool,id=0`, then selecting the `detailedDump` attribute and setting it to `true`. You can now perform the `Server.dump()` operation as explained above, and then set `detailedDump` back to `false`.
-
-[[dump-example]]
-=== Dump Example
-
-Below you can find a simple example of a Jetty Server Dump, with annotations for the principal components:
-
-[jetty.small%nowrap]
-....
-[jetty]
-setupArgs=--add-modules=http
-args=jetty.http.selectors=1 jetty.http.acceptors=1 jetty.threadPool.minThreads=4 jetty.server.dumpAfterStart=true
-delete=^[0-9]\{4}
-callouts= <$N>,Server@,= QueuedThreadPool,HandlerCollection@,= ServerConnector,ManagedSelector@,keys @,startJarLoader@,unmanaged
-....
-ifdef::run-jetty[]
-<1> The `Server` instance at the root of the tree
-<2> The thread pool component
-<3> The root of the `Handler` structure
-<4> The connector listening on port `8080` for the HTTP/1.1 protocol
-<5> A selector component that manages connections
-<6> The connections currently managed by the selector component
-<7> The server `ClassLoader` and its classpath
-<8> The legend for the dump nodes
-endif::[]
-
 [[logging]]
 == Enabling DEBUG Logging
 
@@ -125,7 +57,7 @@ Enabling DEBUG level logging for `org.eclipse.jetty` is very, *very* expensive.
 Your server could be slowed down to almost a halt, especially if it is under heavy load.
 Furthermore, the log file could quickly fill up the entire filesystem (unless configured to roll over), so you want to be really careful using DEBUG logging.
 
-For production servers, consider using the <<dump,Jetty Server Dump>> first, and enable DEBUG logging only as a last resort.
+For production servers, consider using the xref:programming-guide:troubleshooting/component-dump.adoc[Jetty Server Dump] first, and enable DEBUG logging only as a last resort.
 ====
 
 However, sometimes issues are such that only DEBUG logging can really tell what's going on in the system, and enabling DEBUG logging is your best chance to figure the issue out.

documentation/jetty/modules/programming-guide/pages/troubleshooting/component-dump.adoc

@@ -11,16 +11,97 @@
 // ========================================================================
 //
 
-= Component Tree Dump
+[[dump]]
+= Jetty Component Dump
 
-Jetty components are organized in a xref:arch/bean.adoc[component tree].
+Jetty is based on components organized as a tree of Objects (aka beans), with the `Server` or `Client` instance typically at the root of the tree.
 
-At the root of the component tree there is typically a `ContainerLifeCycle` instance -- typically a `Server` instance on the server and an `HttpClient` instance on the client.
+As explained in the xref:operations-guide:jmx/index.adoc[JMX section], these components can be exported as JMX MBeans and therefore be accessible from JMX Consoles such as Java Missions Control (JMC).
 
-`ContainerLifeCycle` has built-in _dump_ APIs that can be invoked either directly on the `Server` instance, or xref:arch/jmx.adoc[via JMX].
+Being able to take a snapshot of a Jetty component tree while it is running is the most useful information that can be attached when reporting an issue as it can contain both configuration and current state of Jetty.
+A dump of the component tree for the Server includes:
 
-You can invoke `Server.dump()` via JMX using a JMX console such as https://adoptium.net/jmc.html[Java Mission Control (JMC)]:
+* The thread pool configuration and its current state, including how many threads are in use, and their stack trace.
+* The Connector configuration (including TLS configuration), state and statistics.
+* The I/O configuration and its current state, including the ports Jetty listens to, how many connections are currently open, and he state of each connection, and the state of the request/response handling for each connection.
+* The `Handler` structure and its configuration.
+* The web applications deployed and their configurations, including the class loader information.
+
+[[dump-start-stop]]
+== Component Dump at Server Start/Stop
+
+You can get the server dump at any time using these methods.
+[,java,indent=0]
+----
+include::code:example$src/main/java/org/eclipse/jetty/docs/programming/ComponentDocs.java[tags=dumpExample]
+----
+
+However, it is often useful to configure the server to dump the state of the freshly started server, and also dump the state just before the `Server` stops (which may be useful to log the state of server that is not working properly).
+[,java,indent=0]
+----
+include::code:example$src/main/java/org/eclipse/jetty/docs/programming/ComponentDocs.java[tags=dumpAfterStartExample]
+----
+
+[NOTE]
+====
+The format of the Jetty Server Dump output is subject to change at any time, as Jetty developers modify the Jetty code and decide to include more state, or remove state that is no longer relevant.
+
+The Jetty Server Dump is organized in a tree whose structure is similar to the runtime Jetty component tree.
+
+At the end of the dump output there is a legend that explains the type of tree node: whether it is a node that represent a _managed_ component, or an _array_ node (or a _map_ node) that represent some component state, etc.
+====
+
+== Obtaining Dump via JMX
+
+The Jetty Component Dump can be obtained by invoking, via JMX, the `Server.dump()` operation, as shown below using https://adoptium.net/jmc.html[Java Mission Control (JMC)]:
 
 image::jmc-server-dump.png[]
 
-TIP: You can get more details from a Jetty's `QueuedThreadPool` dump by enabling detailed dumps via `queuedThreadPool.setDetailedDump(true)`.
+Find the `Server` MBean in the MBean Tree, under `org.eclipse.jetty.server:type=server,id=0`.
+Then click on the "Operations" tab, select the `dump()` operation, and then click the `Execute` button.
+In the bottom panel you will see the result of the invocation, that you can copy into a text editor and save to your file system.
+
+[CAUTION]
+====
+Taking a Jetty Component Dump is a relatively expensive operation, as it dumps the state of all connections (which can be thousands), and the state of all threads.
+
+The result of the invocation may produce a large string, possibly few MiB, that may impact the server memory usage.
+
+Furthermore, dumping the state of the I/O Jetty components takes a little CPU time off the handling of the actual I/O, possibly slowing it down temporarily.
+
+While the slow-down caused by taking the Jetty Component Dump may be noticeable on highly loaded systems, it is typically a very small price to pay to obtain the information about the Jetty state that may be critical to the resolution of an issue.
+====
+
+[[dump-detailed]]
+== Detailed ThreadPool Information
+
+By default, the dump of the thread pool will only dump the topmost stack frame of each thread.
+It is possible to configure the thread pool to dump the whole stack trace for each thread; while this may be a little more expensive, it provides complete information about the state of each thread, which may be important to diagnose the issue.
+
+See the xref:operations-guide:modules/standard.adoc#threadpool[`threadpool` module] configuration for more information about how to configure the thread pool to dump detailed thread information.
+
+Detailed thread pool information can also be turned on/off on-the-fly via JMX, by finding the `ThreadPool` MBean under `org.eclipse.jetty.util.thread:type=queuedthreadpool,id=0`, then selecting the `detailedDump` attribute and setting it to `true`. You can now perform the `Server.dump()` operation as explained above, and then set `detailedDump` back to `false`.
+
+[[dump-example]]
+== Dump Example
+
+Below you can find a simple example of a Jetty Component Dump, with annotations for the principal components:
+
+[jetty.small%nowrap]
+....
+[jetty]
+setupArgs=--add-modules=http
+args=jetty.http.selectors=1 jetty.http.acceptors=1 jetty.threadPool.minThreads=4 jetty.server.dumpAfterStart=true
+delete=^[0-9]\{4}
+callouts= <$N>,Server@,= QueuedThreadPool,HandlerCollection@,= ServerConnector,ManagedSelector@,keys @,startJarLoader@,unmanaged
+....
+ifdef::run-jetty[]
+<1> The `Server` instance at the root of the tree
+<2> The thread pool component
+<3> The root of the `Handler` structure
+<4> The connector listening on port `8080` for the HTTP/1.1 protocol
+<5> A selector component that manages connections
+<6> The connections currently managed by the selector component
+<7> The server `ClassLoader` and its classpath
+<8> The legend for the dump nodes
+endif::[]