Test Statistics Handler #12565
Test Statistics Handler #12565
Conversation
Removed webapp for deleted Stats servlet Updated module name to at least test deployment
|
@lorban currently we have not distribution test for the |
.../test-distribution-common/src/test/java/org/eclipse/jetty/tests/distribution/StatsTests.java
Outdated
Show resolved
Hide resolved
| assertThat(htmlContent, containsString("<em>memory</em>: ")); | ||
| assertThat(htmlContent, containsString("</body>")); | ||
| assertThat(htmlContent, containsString("</html>")); | ||
| // TODO test the StatisticsHandler somehow |
There was a problem hiding this comment.
We could make a couple requests, there already is the one above that returns a 200, and add another one that returns a 404, set dumpBeforeStop to true, then stop the server and check that the 2xxResponses and 4xxResponses counters are part of the dump and have the expected values?
There was a problem hiding this comment.
yeah, but would be good to see requests in progress.
|
|
||
| distribution.installBaseResource("stats-webapp-" + env + "/index.html", "webapps/demo/index.html"); | ||
| distribution.installBaseResource("stats-webapp-" + env + "/WEB-INF/web.xml", "webapps/demo/WEB-INF/web.xml"); | ||
| // TODO add some actual content to it |
There was a problem hiding this comment.
I think this TODO can go away, the StatisticsHandler is installed as the root of the handler tree and there already is a deployed webapp that can be queried to check the stats.
There was a problem hiding this comment.
Currently it is just an empty directory, there is not webapp deployed.
|
@lorban if you want to take over this one... please do.... otherwise I'll get to it later in the week. |
|
@gregw I'm now taking this over. |
|
@lorban status of this one? Are you doing your own branch so I can close this? |
|
@lorban should we wake this one up? |
Signed-off-by: Ludovic Orban <[email protected]>
|
@gregw I added some basic testing of the statistics handler. This should be enough to make sure it basically works, at least for now. |
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
.../test-distribution-common/src/test/java/org/eclipse/jetty/tests/distribution/StatsTests.java
Outdated
Show resolved
Hide resolved
.../test-distribution-common/src/test/java/org/eclipse/jetty/tests/distribution/StatsTests.java
Outdated
Show resolved
Hide resolved
.../test-distribution-common/src/test/java/org/eclipse/jetty/tests/distribution/StatsTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
Removed webapp for deleted Stats servlet
Updated module name to at least test deployment