Use \clearpage for newpage option to respect floats#5
Open
bschne wants to merge 5 commits intojez:masterfrom
Open
Use \clearpage for newpage option to respect floats#5bschne wants to merge 5 commits intojez:masterfrom
bschne wants to merge 5 commits intojez:masterfrom
Conversation
This change uses the "partCounter" when working with either \alphaparts or \arabicparts question parts. This allows for splitting the list of question parts with some additional question text in between (i.e. using more than one \alphaparts or \arabicparts environment within a question) while still getting a continued enumeration label within the same question.
Use partCounter in question parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
newpageclass option currently works by adding a\newpagecommand before each named or numbered question.This has the counterintuitive effect that sometimes floats (e.g. a figure) from a previous question get put on top of the next page where the following question starts, and pushing the question header down on said page.
IMHO the intention of the
newpageclass option is to have each question begin at the top of it's own, new page.This pull request therefore changes this to use the
\clearpagecommand instead of\newpageto handle this case and ensure that the header of a new question is always at the top of its own, new page.