Skip to content

Re-enable check against FallThrough violations #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
regisd wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Re-enable check against FallThrough violations #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00a7dd2
Re-enable check against FallThrough violations
regisd Sep 22, 2018
41c70f6
Merge branch 'master' into error-prone
regisd Oct 15, 2018
f231e15
Merge branch 'master' into error-prone
regisd Nov 23, 2019
5a5ef07
Increase FallThrough to warn in Bazel.
regisd Nov 24, 2019
8f3d58c
Merge branch 'master' into error-prone
regisd Dec 1, 2019
24c68d7
Merge branch 'master' into error-prone
Dec 7, 2019
e58918d
Merge branch 'master' into error-prone
regisd Dec 12, 2019
cbf80cc
Merge branch 'master' into error-prone
lsf37 Mar 15, 2020
9906146
Merge branch 'master' into error-prone
regisd Mar 28, 2020
2b108e4
Merge branch 'master' into error-prone
regisd Apr 10, 2020
b8abacc
Merge branch 'master' into error-prone
regisd May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,7 @@ build --javacopt "-Xep:EqualsIncompatibleType:ERROR"
build --javacopt "-Xep:EqualsUnsafeCast:ERROR"
build --javacopt "-Xep:EqualsUsingHashCode:ERROR"
build --javacopt "-Xep:ExtendingJUnitAssert:ERROR"
# TODO(#222) Increase to error when we build from jflex-1.7.1 with a lexer annotated with
# @SuppressWarnings
build --javacopt "-Xep:FallThrough:WARN"
build --javacopt "-Xep:FallThrough:ERROR"
build --javacopt "-Xep:Finally:ERROR"
build --javacopt "-Xep:FloatCast:ERROR"
build --javacopt "-Xep:FloatingPointAssertionWithinEpsilon:ERROR"
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
<target>8</target>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne -Xep:FallThrough:WARN</arg>
<arg>-Xplugin:ErrorProne</arg>
</compilerArgs>
<annotationProcessorPaths>
<path>
Expand Down