-
Notifications
You must be signed in to change notification settings - Fork 34
improvements and security fixes #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed unnecessary docs
📗 Scan Summary
|
| public class JFrogPlatformBuilder extends GlobalConfiguration { | ||
| // frogbot:ignore insecure-protocol - Protocol constant for validation, actual usage is gated by allowHttpConnections security flag | ||
| @SuppressWarnings("HttpUrlsUsage") | ||
| private static final String[] KNOWN_PROTOCOLS = {"http://", "https://", "ssh://"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Static Application Security Testing (SAST) Vulnerability
Full description
Vulnerability Details
| Rule ID: | java-insecure-protocol |
Overview
Using insecure protocols—such as HTTP, FTP, or LDAP—can expose sensitive
data during transmission, making it vulnerable to eavesdropping and man-in-the-middle
attacks. Secure protocols like HTTPS and FTPS should be used to ensure data
encryption during communication.
Vulnerable example
In this example, the application uses insecure protocols to communicate,
taking the protocol type from hardcoded strings.
import java.io.IOException;
import java.net.URL;
import java.net.URLConnection;
public class insecure_protocol_vuln {
public void connectToFrogService(String server) throws IOException {
String insecureHttpProtocol = "http://"; // Insecure protocol
String url = insecureHttpProtocol + server + "/frogEndpoint";
URL obj = new URL(url);
URLConnection conn = obj.openConnection(); // Vulnerable: Insecure protocol
conn.connect();
}
}Remediation
To mitigate the use of insecure protocols, replace them with secure alternatives
such as HTTPS or FTPS.
import java.io.IOException;
import java.net.URL;
import java.net.URLConnection;
import javax.net.ssl.HttpsURLConnection;
public class insecure_protocol_safe {
public void connectToFrogService(String server) throws IOException {
String secureHttpProtocol = "https://"; // Secure protocol
String url = secureHttpProtocol + server + "/frogEndpoint";
URL obj = new URL(url);
HttpsURLConnection conn = (HttpsURLConnection) obj.openConnection(); // Safe: Secure protocol
conn.connect();
}
}
<br></details>
---
<div align='center'>
[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
</div>
agrasth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I can see we are checking for safe to test before pr audit, but seems like remove label step is not added.
github actions removeLabel workflow is available here https://github.com/jfrog/jenkins-jfrog-plugin/actions/workflows/remove-label.yml |


Uh oh!
There was an error while loading. Please reload this page.