Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track wikilinks with a class instead of the title #160

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

silby
Copy link
Contributor

@silby silby commented Feb 6, 2025

The use of title="wikilink" in HTML output likely traces back to Pandoc's hijacking of the title attribute for this purpose back when Pandoc links didn't have Attrs. A coordinated change in Pandoc moves this more appropriately into a class.

The use of title="wikilink" in HTML output likely traces back to
Pandoc's hijacking of the title attribute for this purpose back when
Pandoc links didn't have Attrs. A coordinated change in Pandoc moves
this more appropriately into a class.
silby added a commit to silby/pandoc that referenced this pull request Feb 6, 2025
I plan to drop this commit and replace with jgm's repo once
jgm/commonmark-hs#160 is merged
@silby
Copy link
Contributor Author

silby commented Feb 7, 2025

They’re changed in the parallel Pandoc pr, jgm/pandoc#10599

@jgm
Copy link
Owner

jgm commented Feb 7, 2025

Yeah, just realized that this is commonmark!

@jgm jgm merged commit 99af4b2 into jgm:master Feb 7, 2025
7 checks passed
silby added a commit to silby/pandoc that referenced this pull request Feb 7, 2025
I plan to drop this commit and replace with jgm's repo once
jgm/commonmark-hs#160 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants