Skip to content

Use glog to replace revel's logging system. Be compatible with newest re...#4

Open
AllenDang wants to merge 2 commits into
jgraham909:masterfrom
AllenDang:master
Open

Use glog to replace revel's logging system. Be compatible with newest re...#4
AllenDang wants to merge 2 commits into
jgraham909:masterfrom
AllenDang:master

Conversation

@AllenDang

Copy link
Copy Markdown

...vel.

@jgraham909

Copy link
Copy Markdown
Owner

This diff seems excessive did you 'go fmt' the code before committing?

@AllenDang

Copy link
Copy Markdown
Author

Yes, I go fmt it.

@jgraham909

Copy link
Copy Markdown
Owner

That's strange. I'm running go 1.1.1 and my go fmt produces a different layout than yours.

Can you confirm your go version?

Also is this for revel's v1 branch?

@AllenDang

Copy link
Copy Markdown
Author

my go version is 1.1.2.

Yes, that is for revel's v1 branch.

2013/9/25 Jeff Graham notifications@github.com

That's strange. I'm running go 1.1.1 and my go fmt produces a different
layout than yours.

Can you confirm your go version?

Also is this for revel's v1 branch?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-25066543
.

@jgraham909

Copy link
Copy Markdown
Owner

Sorry I've left this lingering. I just pushed a v1 branch would you mind re-rolling against that branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants