Update README to emphasize Ruby version requirement #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How did you install vernier without the minimum Ruby version? 😅 We should be enforcing it via gemspec https://github.com/jhawthorn/vernier/blob/main/vernier.gemspec#L15 |
|
I suspect they got an older version? e.g. https://rubygems.org/gems/vernier/versions/0.1.0 |
|
Ah! 😓 that makes sense. Maybe I should cut a 1.0 as well and specify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the minimum Ruby version requirement so that users do not spend time wondering why the Vernier traces are malformed and fail to render in the profile viewers☺️