Open
Conversation
Dear All, I have modified our validation note based on Jack's comments in the attached files. (I also attached the one from Jack.) Please read them carefully ! All modifications are marked in BLUE, but still one question (marked in RED) is left. On the other hand, I don't know how to modify the text on the page 3 to avoid them like a shopping list. If you have a better way to deal with them, please directly refine them. Thanks ! I will wait for your feedback, and then reply to Jack. Thanks a lot ! Best regards, Chih-Ting
The selection efficiency ... are ... -> The selection efficiency ... is ...
as an attempt to address Jack's comment on it: "This sounds like a shopping list".
as an attempt to address Jack's comment on it: "This sounds like a shopping list".
as an attempt to address Jack's comment on it: "This sounds like a shopping list".
Owner
Author
|
I added three more commits in an attempt to restyle the "shopping-list"-like paragraphs. |
timlu0125
requested changes
May 25, 2020
Collaborator
timlu0125
left a comment
timlu0125
left a comment
There was a problem hiding this comment.
Dear All,
Sorry for my late reply ! I am satisfied with Jae-hyeon's updates.
For Jiwon,
Could you help to rephrase the sentence before Jae-hyeon's comment ?
" \textcolor{magenta}{It might be unclear what you mean by ``the loosened isolation criteria''. I do not find its definition in the text either.} "
Since this sentence is original from you, it's better that you can modify this part. Thank you !
After this part has been modified, I think our updated note should be okay in this status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly Chih-Ting's implementation of Jack's suggestions plus small changes from me.
I am still planning to rewrite the "shopping-list"-like paragraphs.