Fix excel routed dtype latency - #13
Closed
ZZZxwx wants to merge 23 commits into
Closed
Conversation
寻优脚本优化,在format_result的时候增加缓存
支持pp开低精度、开overlap
支持pp开低精度、开overlap
Fix/ep comm fix
2.add xlsx test
Fix DualPipeV VPP scheduling accounting
1.fix dsv4 PARAM_SCOPE miss 2.add xlsx test
寻优允许pp=1情况,增加hidden限制
Fix HC and RMSNorm sharding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 spec-based 训练 Excel 报表中 Ops sheet 的 per-op latency 展示问题。
此前最终 Step Time 计算路径已经会根据 op.component 解析 compute dtype,例如 routed expert 使用 routed_expert_compute_dtype,但 Excel exporter 在单算子 Latency (μs) 展示时没有传入该 dtype,导致 routed expert 在 FP8/FP4 配置下仍按默认 BF16 peak 显示 latency。
本 PR 将 Excel exporter 的 per-op latency 计算改为复用 _resolve_compute_dtype(op, model),并把解析出的 dtype 传给 _cost_phase_time(),使 Excel 中 routed expert 的 latency 与最终训练时间估算路径保持一致。
同时新增回归测试,覆盖 routed expert FP8 compute + FP4 weight 场景,验证 Excel Ops sheet 的 latency 使用 routed compute dtype,而不是 BF16 默认路径。