Repository navigation
List leftover dash processes with watch identity - #1057
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator summary
Before
After a PATH install, leftover dashboard processes (including version-suffixed binaries) were only visible by inspecting process tables by hand. Status described the new install; old loopback binds stayed up.
Change
flotilla watch identitylists running watch and dash processes: disk hash, executable hash, revision, deleted-inode flag, and dash listen addresses. Version-suffixedflotilla-<build>dash leftovers are included. The command is list-only; it does not kill.After
An operator can see leftover dashboard binds and deleted inodes without sending signals.
Identifiers
5137a2243673f6b852e8ec69f5039958ec271219agent/retro-0905-p1-e-watch-identitySummary
Process admission accepts basename
flotillaor aflotilla-prefix. Non-flotilla binaries stay ignored. No kill or signal path.Independent review: code-clean at this exact successor head. Not installed. A leftover dash bind on the host is not reaped by this PR.
Summary by cubic
Adds the
flotilla watch identitycommand so operators can see leftover dashboard processes and deleted inodes without inspecting process tables by hand.flotilla-<build>dash leftovers.Written for commit 8910ef2. Summary will update on new commits.