Skip to content

Removing reference to window object, to make oboe.js usable with web workers.#226

Open
paulsmithkc wants to merge 1 commit into
jimhigson:masterfrom
paulsmithkc:master
Open

Removing reference to window object, to make oboe.js usable with web workers.#226
paulsmithkc wants to merge 1 commit into
jimhigson:masterfrom
paulsmithkc:master

Conversation

@paulsmithkc

@paulsmithkc paulsmithkc commented Nov 24, 2020

Copy link
Copy Markdown

Line 2774 references window.location instead of location
Line 2788 references window.setTimeout instead of setTimeout

Simply changing these two lines so that they refer to the default global object instead window makes oboe.js usable in a web worker.

Linked Issue #225

@paulsmithkc

Copy link
Copy Markdown
Author

ping @jimhigson

@paulsmithkc

paulsmithkc commented Feb 16, 2022

Copy link
Copy Markdown
Author

bump This is a blocking issue for using oboe.js with web workers, which results in a massive performance boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant