Add helm managed overrides to audio/video datasets#1
Open
charlesbluca wants to merge 2 commits intojioffe502:audio_video_retrievalfrom
Open
Add helm managed overrides to audio/video datasets#1charlesbluca wants to merge 2 commits intojioffe502:audio_video_retrievalfrom
charlesbluca wants to merge 2 commits intojioffe502:audio_video_retrievalfrom
Conversation
jioffe502
reviewed
Feb 9, 2026
tools/harness/test_configs.yaml
Outdated
| # Video dataset (96 files, ~54 GB) | ||
| video: | ||
| path: /path/to/video_retrieval_data | ||
| path: /localhome/charlesb/datasets/video_retrieval_data |
Owner
There was a problem hiding this comment.
we have to change back these paths to default
jioffe502
approved these changes
Feb 9, 2026
Owner
jioffe502
left a comment
jioffe502
left a comment
There was a problem hiding this comment.
happy to merge after these small changes
tools/harness/test_configs.yaml
Outdated
| datasets: | ||
| bo767: | ||
| path: /path/to/bo767 | ||
| path: /localhome/charlesb/datasets/bo767 |
Owner
There was a problem hiding this comment.
Suggested change
| path: /localhome/charlesb/datasets/bo767 | |
| path: /path/to/bo767 |
tools/harness/test_configs.yaml
Outdated
| # Video dataset (96 files, ~54 GB) | ||
| video: | ||
| path: /path/to/video_retrieval_data | ||
| path: /localhome/charlesb/datasets/video_retrieval_data |
Owner
There was a problem hiding this comment.
Suggested change
| path: /localhome/charlesb/datasets/video_retrieval_data | |
| path: /path/to/video_retrieval_data |
tools/harness/test_configs.yaml
Outdated
| # Audio dataset (MP3 files for audio retrieval) | ||
| audio: | ||
| path: /path/to/audio_retrieval_data_mp3 | ||
| path: /localhome/charlesb/datasets/audio_retrieval_data_mp3 |
Owner
There was a problem hiding this comment.
Suggested change
| path: /localhome/charlesb/datasets/audio_retrieval_data_mp3 | |
| path: /path/to/audio_retrieval_data_mp3 |
tools/harness/test_configs.yaml
Outdated
| gpu_search: false # Use GPU for search | ||
| embedding_model: auto # auto-detect or specify model name | ||
| vdb_backend: lancedb # milvus or lancedb | ||
| vdb_backend: milvus # milvus or lancedb |
Owner
There was a problem hiding this comment.
we are technically defaulting to lancedb. not sure if you have hesitations for this for helm. LMK
Owner
There was a problem hiding this comment.
definitely default to lance now
jioffe502
pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.