Skip to content

fixes resize event stutter on iOS devices #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taberrr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes resize event stutter on iOS devices #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jquery.ellipsis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,13 +210,19 @@

// only bind to window resize if required
if (base.opts.responsive) {
var windowWidth = $(window).width();

/**
* resize() resets necessary vars
* and content and then re-initialises
* the Ellipsis script
*/
var resize = function() {
if ($(window).width() == windowWidth) {
return;
}
windowWidth = $(window).width();

Copy link
Owner

@jjenzz jjenzz Jul 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taberrr, thanks for this fix. It would be great if you could cache the window reference and add a comment explaining why this is required though please if you don't mind?

if (base.opts.responsive) {
  var $window = $(window);
  var windowWidth = $window.width();

  var resize = function() {
    // Scrolling on iOS6+ fires the resize event. This ensures the width has actually changed
    // before continuing. https://tinyurl.com/ios-scroll-resize
    if ($window.width() === windowWidth) {
      return;
    }
    
    windowWidth = $window.width();
    //etc.
  }

  $window.on('resize.' + namespace, resize);
}

lines = [];
currLine = 0;
currOffset = null;
Expand Down
2 changes: 1 addition & 1 deletion jquery.ellipsis.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.