Hook browser back/forward to nav state#251
Merged
Merged
Conversation
Push history on user-initiated navigation so 'Back' moves between views instead of leaving the app. - urlHash: add pushUrlHash/pushSettingsHash (pushState variants) - useConversationRouter: pushState on nav; popstate resolves hash to conversation without re-pushing; switch over if-chain - useAppShell: pushState on settings open; popstate syncs visibility; close via history.back() when we own the entry - Tests: popstate coverage in appStartupHash + useAppShell
Owner
|
I've tacked a few minor fixes onto this -- happy for me to merge? |
Contributor
Author
|
Of course, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #250
Screencast_20260511_022910.webm
Push history on user-initiated navigation so 'Back' moves between views instead of leaving the app.
Claude did that code btw.