Reorganize project structure

[jmcpheron]

No description provided.

[claude]

Claude finished @jmcpheron's task —— View job

---

Code Review: Project Reorganization

Todo List:

• Analyze project structure and understand current setup
• Review deleted files and their impact
• Examine page file reorganization (moved to pages/ directory)
• Check extraction map file changes
• Assess development workflow impact
• Evaluate security implications
• Check for potential bugs or issues
• Provide comprehensive feedback

---

Review Summary

This PR successfully reorganizes the project structure with significant cleanup and modernization. Overall, the changes improve organization and adopt modern Python development practices.

✅ Positive Changes

1. Improved Project Organization

• Moving page files to dedicated pages/ directory creates better logical separation
• Follows common project structure patterns with dedicated directories for different file types

2. Modernized Development Workflow

• Replaced Makefile and requirements-dev.txt with modern pyproject.toml configuration
• Adopted uv for dependency management (faster, more reliable than pip)
• Comprehensive tool configuration (ruff, mypy, pytest) in single pyproject.toml file

3. Cleanup of Legacy Files

• Removed CLAUDE.local - appropriate for version control hygiene
• Removed sample-git-hooks/ - likely unused development artifacts
• Removed README_LITERALS.md - documentation consolidated elsewhere

🔧 Technical Assessment

File Organization: pages/pages.efgByStu.json:2

• Extraction maps correctly updated to reflect new file paths
• source_file field properly references pages/pages.efgByStu.json

Build System Migration: pyproject.toml:47-54

• Comprehensive linting configuration with sensible rule selection
• Proper exclusion of extracted_literals from linting (appropriate for generated content)
• Modern Python version targeting (>=3.9)

⚠️ Potential Issues & Recommendations

1. Documentation Gap

• README_LITERALS.md was removed (226 lines) but functionality remains
• Recommendation: Ensure literal extraction process is documented elsewhere, perhaps in main README.md

2. CLAUDE.md Update Needed

• File naming convention section still references root-level page files: pages.{identifier}.json
• Recommendation: Update CLAUDE.md:39-41 to reflect new pages/pages.{identifier}.json structure

3. Potential Breaking Changes

• Any external tooling referencing root-level page files will break
• Recommendation: Verify no CI/CD pipelines or deployment scripts reference old paths

🔒 Security Analysis

• ✅ No security issues identified
• Removal of local configuration files (CLAUDE.local) reduces risk of secret exposure
• No hardcoded credentials or sensitive data in remaining files

🚀 Performance Considerations

• ✅ No performance impact
• File reorganization doesn't affect runtime behavior
• Extraction map updates maintain functionality without performance penalty

📊 Test Coverage Impact

• ✅ Test structure remains intact
• All test files preserved in tests/ directory
• Modern pytest configuration properly maintained in pyproject.toml

Action Items

1. Update CLAUDE.md file naming convention documentation
2. Verify external tooling compatibility with new file paths
3. Consider adding migration notes to README.md if any users need to update references

Overall Assessment

Approval Recommended ✅

This is a well-executed reorganization that improves project maintainability while modernizing the development workflow. The changes follow Python best practices and create a more professional project structure.

---