py2/py3 compatability#16
Open
tedder wants to merge 19 commits intojmoiron:masterfrom
Open
Conversation
- basestring to str - decode for text parsing - iteritems() to items() - commented out unused code; lxml isn't imported and the variables aren't assigned outside of that scope.
- bump version - add 'future' as required module - remove unused imports from setup - fix futures imports in speedparser itself - remove a debug line from speedparser I can run the tests but several of them fail for a missing `feeds/` directory. I assume that only exists on jmoiron's box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
speedparser is now fully compatible (for me at least). Unit tests mostly work, but there are several that depend on data that isn't committed.