Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CH546 support from drizzt #49

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

jnweiger
Copy link
Owner

@jnweiger jnweiger commented Aug 8, 2024

No description provided.

@Sandr0x00
Copy link

I added a PR to fix exactly this issue to a forked repo (fossasia#12) which seems to be also containing all further improvements in this PR. Maybe this helps fixing the issue also on this repo by cherry picking, if you don't want the other improvements?
Be aware, I did not test the fix with other devices other than my own CH546, so I'm not aware if my fix breaks other devices.

@jnweiger
Copy link
Owner Author

jnweiger commented Jan 12, 2025

I have lost overview here. Cannot estimate, how much energy is needed to resolve git conflicts.
fossasia seems to be cleanly ahead by 16 commits - if git allows a clean merge back from there, then I am probably happy with that too.

@Sandr0x00
Copy link

Sandr0x00 commented Jan 13, 2025

clean merge should be possible from there (except my PR is not yet merged, so the fix is not yet in there), on the other side, I can also prepare a PR for your repo only containing the fix for CH546. But as previously said, "works with my machine" and I have no way of verifying if it works with others :)
But since multiple people have the issue, it may be worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants