Repository navigation
chore(dashboard): drop overlay classes that never applied - #988
Merged
Merged
Conversation
- `duration-150` on Dialog and AlertDialog content: its animation-duration equals tailwindcss-animate's default and loses on specificity to `data-[state=open]:animate-in`; the transition-duration it also set only reached radius and max-width when a window was resized across 640px with a dialog open. - `data-[state=open]:*` on the Dialog and Sheet close buttons: Radix's Close carries no data-state. - `transition-opacity` on the same buttons: the global press rule in index.css (0,2,1) sets transition-property on every button and wins over it, so the hover opacity change was always instant. - `disabled:pointer-events-none` on the same buttons: Close takes no props from the caller, so it is never disabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the main change: removing unused overlay classes from the dashboard. |
| Description check | |
The description explains the changes and rationale, documents the limited resizing behavior, completes the checklist, and references the related review document. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #984: removes overlay classes that never applied, so the class strings say only what renders.
duration-150on Dialog and AlertDialog content — equals tailwindcss-animate's default animation duration (and loses on specificity todata-[state=open]:animate-in).data-[state=open]:*on the Dialog and Sheet close buttons — Radix's Close carries nodata-state.transition-opacityon those buttons — the global press rule inindex.css(specificity 0,2,1) sets every button'stransition-property, so the hover opacity change was already instant.disabled:pointer-events-noneon those buttons — Close takes no caller props and is never disabled.No rendered change, apart from the transition-duration
duration-150also set, which only reached radius and max-width when a window was resized across 640px with a dialog open.Checklist
anyagent-corefirst — n/aRelated
.work/docs.work/reviews/chore__dashboard-dialog-dead-classes.md— one adversarial channel, verified against built CSS and Radix source🤖 Generated with Claude Code
Summary by CodeRabbit