Repository navigation
fix(dashboard): platform badges say iOS, not Ios - #992
Merged
Merged
Conversation
The badge printed the API's lowercase platform and let CSS capitalize it, which cannot produce iOS. A PLATFORM_LABEL map names each platform the way AddAppDialog's select already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the badge fix: "No agents available for ios." printed the same raw value. Also moves the new settings test above the comment that belongs to the QA test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Platform badges in App Center's build rows and Settings → Apps rendered the API's lowercase
platformwith CSScapitalize, so they read "Ios". APLATFORM_LABELmap inlib/build-format.ts(iOS,Android,Both, as AddAppDialog's select already writes them) now names the platform there and in the QA session's "No agents available for …" line, which printed the raw value. Found while writing the Badge spec (#991).Checklist
anyagent-corefirst — n/aRelated
.work/docs.work/reviews/fix__dashboard-platform-label.md— one adversarial channel, 2 findings, both fixed🤖 Generated with Claude Code
Summary by CodeRabbit