Skip to content

fix(dashboard): platform badges say iOS, not Ios - #992

Merged
jo-duchan merged 2 commits into
mainfrom
fix/dashboard-platform-label
Oct 18, 2026
Merged

jo-duchan merged 2 commits into
mainfrom
fix/dashboard-platform-label

Conversation

@jo-duchan

@jo-duchan jo-duchan commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Platform badges in App Center's build rows and Settings → Apps rendered the API's lowercase platform with CSS capitalize, so they read "Ios". A PLATFORM_LABEL map in lib/build-format.ts (iOS, Android, Both, as AddAppDialog's select already writes them) now names the platform there and in the QA session's "No agents available for …" line, which printed the raw value. Found while writing the Badge spec (#991).

Checklist

  • Tests written and passing — BuildRow, DefaultSettings.load and QASession tests assert the exact label; each fails on the old code
  • No any
  • Interface changes land in agent-core first — n/a
  • No sensitive info (tokens, paths, credentials)
  • I verified this change myself — dashboard suite green
  • AI use disclosed, if any — written with Claude Code

Related .work/ docs

  • Review: .work/reviews/fix__dashboard-platform-label.md — one adversarial channel, 2 findings, both fixed

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Standardized platform names across App Center build rows, Settings → Apps, and QA session messages. Platforms now display as “iOS,” “Android,” or “Both” instead of inconsistent capitalization.

jo-duchan and others added 2 commits October 18, 2026 16:13
The badge printed the API's lowercase platform and let CSS capitalize it, which
cannot produce iOS. A PLATFORM_LABEL map names each platform the way AddAppDialog's
select already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of the badge fix: "No agents available for ios." printed the same raw value.
Also moves the new settings test above the comment that belongs to the QA test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
tapflow-docs Ignored Ignored Oct 18, 2026 7:17am UTC

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: jo-duchan/tapflow/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: a0a0efec-ba8c-4be3-b136-ffbc046bb0a3
📥 Commits

Reviewing files that changed from the base of the PR and between 150f6bd and e731f1f.

📒 Files selected for processing: 9
  • .changeset/dashboard-platform-label.md
  • CHANGELOG.md
  • packages/dashboard/components/app-center/BuildRow.tsx
  • packages/dashboard/lib/build-format.ts
  • packages/dashboard/src/__tests__/BuildRow.test.tsx
  • packages/dashboard/src/__tests__/DefaultSettings.load.test.tsx
  • packages/dashboard/src/__tests__/QASession.aiHolder.test.tsx
  • packages/dashboard/src/pages/QASession.tsx
  • packages/dashboard/src/pages/settings/Default.tsx

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The dashboard now uses a typed platform-label mapping in build rows, Settings → Apps, and the QA session’s empty-agent message. Tests and release notes cover the updated labels.

Changes: Dashboard platform labels

Layer / File(s) Summary
Define platform labels
packages/dashboard/lib/build-format.ts
Adds a type-checked mapping for ios, android, and both to iOS, Android, and Both.
Use labels in dashboard views
packages/dashboard/components/app-center/BuildRow.tsx, packages/dashboard/src/pages/settings/Default.tsx, packages/dashboard/src/pages/QASession.tsx, packages/dashboard/src/__tests__/*, CHANGELOG.md, .changeset/dashboard-platform-label.md
Build rows, settings, and the QA empty-agent message use the mapped labels. Tests check rendered labels. The changelog and changeset describe the updates.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to e731f

Build rows, Settings → Apps, and the QA empty state now display the intended platform names instead of raw or CSS-capitalized values. No material merge risk is established by the supplied context.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 7 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary change: correcting dashboard platform labels from "Ios" to "iOS".
Description check Passed The description includes the required Summary, Checklist, and Related .work/ docs sections. It explains the change, records test coverage, confirms checklist items, and identifies the related review…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the required Summary, Checklist, and Related .work/ docs sections. It explains the change, records test coverage, confirms checklist items, and identifies the related review document.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 7 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jo-duchan jo-duchan mentioned this pull request Oct 18, 2026
6 tasks done
@jo-duchan
jo-duchan merged commit d28e1ab into main Oct 18, 2026
16 checks passed
@jo-duchan
jo-duchan deleted the fix/dashboard-platform-label branch October 18, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant