fix: detect zombie browser context in getSession() to prevent 30s tab timeouts#5416
Open
Love-JourneY wants to merge 1 commit into
Open
fix: detect zombie browser context in getSession() to prevent 30s tab timeouts#5416Love-JourneY wants to merge 1 commit into
Love-JourneY wants to merge 1 commit into
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: proactive zombie context detection
Problem
getSession()at line 1142-1148 usessession.context.pages()as a health probe — but this is synchronous and returns cached data even when the underlying CDP connection is dead. WhennewPage()is subsequently called on a zombie context, it hangs for 30s.Evidence
Root Cause
The project already tracks
healthState.lastSuccessfulNav(line 633) and has an active health probe (lines 5949-5980) at 60s intervals. But between probes, a zombie context can go undetected.Fix
Add a staleness check after the existing
pages()probe — if no successful navigation in 120s, recreate the context proactively:Scope
server.jshealthState.lastSuccessfulNavtimestampCloses #5415