-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to the jdk client version 0.10.0 #139
Open
domaspoliakas
wants to merge
7
commits into
joan38:main
Choose a base branch
from
domaspoliakas:jdk-0.7.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! Thanks for submitting a PR! |
Thanks for that! I'll see if I can get minikube set up and debug these issues. |
Tests failing with 0.9.1, maybe related to http4s/http4s-jdk-http-client#116 |
I added this pipe to the ws connection streams to deal with the private def skipConnectionClosedErrors: Pipe[F, WSDataFrame, WSDataFrame] =
_.map(_.some)
.recover {
// Need to handle (and ignore) this exception
//
// Because of the "conflict" between the http4s WS client and
// the underlying JDK WS client (which are both high-level clients)
// an extra "Close" frame gets sent to the server, potentially
// after the TCP connection is closed, which causes this exception.
//
// This will be solved in a later version of the http4s (core or jdk).
case e: java.io.IOException if e.getMessage == "closed output" => none
}
.unNone Also changed the return type of the Resource[F, F[Stream[F, Either[ExecStream, ErrorOrStatus]]]] to this: Stream[F, Either[ExecStream, ErrorOrStatus]] pod tests passed locally for me |
ec9a47d
to
9b3f1d6
Compare
# Conflicts: # kubernetes-client/src/com/goyeau/kubernetes/client/KubernetesClient.scala
…e of `PodsApi#execStream`, minor refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I hope it's ok to open a PR directly without an issue first.
This PR upgrades the http4s jdk client to
0.7.0
.0.7.0
is not binary-compatible with0.5.0
, so this is necessary if the downstream users (me 😄 ) wish to upgrade the jdk client.I couldn't run tests because I don't have minikube set up. I'm hoping CI will catch anything that could be a problem, although the changes themselves are very straightforward.
Let me know if there's anything else that needs to be done!