Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mill to 0.11.13 #308

Merged
merged 9 commits into from
Feb 2, 2025
Merged

Update Mill to 0.11.13 #308

merged 9 commits into from
Feb 2, 2025

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jan 29, 2025 •
edited
Loading

  • Update Scala 3 to 3.3.4

@lolgab
Copy link
Contributor Author

lolgab commented Jan 29, 2025

Hello @joan38, @yurique :)
Can you approve the workflows?

@lolgab
Copy link
Contributor Author

lolgab commented Jan 29, 2025

Can you approve again?

@yurique @joan38

@lolgab
Copy link
Contributor Author

lolgab commented Jan 29, 2025

Again 🙈 @yurique

@lolgab
Copy link
Contributor Author

lolgab commented Jan 29, 2025

By the way, GitHub UX sucks when approvals are needed 🙈

@lolgab
Copy link
Contributor Author

lolgab commented Feb 2, 2025

I need yet another approval @yurique

@lolgab lolgab marked this pull request as ready for review February 2, 2025 15:08
@lolgab
Copy link
Contributor Author

lolgab commented Feb 2, 2025

@yurique Finally ready for review 🎉

@joan38 joan38 merged commit 97fbd6a into joan38:main Feb 2, 2025
7 checks passed
@joan38
Copy link
Owner

joan38 commented Feb 2, 2025

Nice! Thanks @lolgab

@lolgab lolgab deleted the update-mill branch February 2, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joan38 joan38 joan38 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgab @joan38