ToString for CSV Parser results #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgduarte
requested changes
Dec 5, 2022
| Given array of structs from the parsed csv, prints out the contents of the file parsing in a nice string format. | ||
| The input of the function can take in any type of structs with any number of fields within the struct. | ||
| */ | ||
| func ParseToString(arr []interface{}) string { |
There was a problem hiding this comment.
Thank you for contributing!
I like the idea of having a ParseToString helper. Maybe we could just put this function in a new .go file? Maybe a file with the name helpers.go.
Also, could you add a unit test or two? It would be nice to have everything tested.
| for i, s := range res { | ||
| translate[i] = s | ||
| } | ||
| resultString := parseToString(translate) |
There was a problem hiding this comment.
It should be csvparser.ParseToString(translate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParseToString() function added to the parser file allows a user to input their parsed structs and get back a string version of its contents. The function prints the values of the structs regardless of the var types for the fields within each struct.