Skip to content

optimize - #13

Open
p2world wants to merge 1 commit into
joaquimserafim:masterfrom
p2world:master
Open

optimize#13
p2world wants to merge 1 commit into
joaquimserafim:masterfrom
p2world:master

Conversation

@p2world

@p2world p2world commented Sep 7, 2017

Copy link
Copy Markdown

No description provided.

@benatkin

benatkin commented May 8, 2018

Copy link
Copy Markdown

The RegExp /[_-+]/g is invalid, and needs to be changed to /[_\-+]/g. I got the error when setting up a jsperf, and I see the same error in the Travis CI job log:

/home/travis/build/joaquimserafim/base64-url/index.js:12:23: Parsing error: Error parsing regular expression: Invalid regular expression: /[_-+]/: Range out of order in character class

Also I wasn't sure it was faster, but it is according to this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants