This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Added maximum height for multiline label. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be configured by using .multiline(<#maxHeight#>).
victorBaro
reviewed
Mar 19, 2019
Contributor
victorBaro
left a comment
victorBaro
left a comment
There was a problem hiding this comment.
I love your PR. The only thing I am a bit concern about is making the api more "ugly".
I don't like this:
sut.type = .multiline(maxHeight: nil)
It would be great if we could have default values to associated values.
Or we could have a new case, something like:
case multiline
case multilineRestricted(maxHeight: CGFloat)That would allow us to get rid of the optional. What do you think?
Contributor
Author
|
Thank you for your suggestion! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a response to #105. It implements a maximum height for a multiline TextView.
The new limit can be configured by setting an associated value to the
AnimatedTextInputType-Enum case.multilinelike this:.multiline(maxHeight: 150).If the multiline label should not be limited in height, the user specifies
.multiline(maxHeight: nil).