fix: use gtag API for GA4 event tracking#118
Merged
Conversation
trackEvent was pushing plain objects to dataLayer (GTM format), but the app uses gtag.js which only processes Arguments objects from gtag() calls. All custom GA events were silently dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trackEventwas pushing plain objects todataLayer(GTM format), but the app usesgtag.jswhich only processesArgumentsobjects fromgtag()calls.window.dataLayer?.push({event, ...params})towindow.gtag?.('event', event, params)— the correct gtag.js API.Test plan
apply_button_clickedevent fires in GA4 DebugView when clicking Apply on a jobfilter_applied,job_card_clicked) also appear in GA4 DebugView