Repository navigation
Support Apple container CLI 1.5.0 - #28
Merged
Merged
Conversation
Capture 1.5.0 JSON fixtures and run the frontend and Rust fixture tests against both 1.4.1 and 1.5.0. The JSON shapes the app reads are unchanged, so no app code changes were needed. The live smoke test now accepts any supported version and passed against 1.5.0. The machine initialization workaround is still required in 1.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for container 1.5.0 and keeps 1.4.1 supported.
What changed
src/test/fixtures/container-1.5.0/, covering system status, containers, stats, images, machines, volumes, networks, and builder.container-*fixture set and runs once per set. The stats, builder, system-status, and recreation tests now check both 1.4.1 and 1.5.0.live_1_4_1_smoketolive_smoke. It accepts any version inSUPPORTED_VERSIONS.docs/container-1.4.1.mdtodocs/container-1.5.0.mdand added a 1.5.0 section. Updated the README and the CI comment.Findings
container k8s start. The app doesn't use Kubernetes.image lslists every platform variant. The app still shows the arm64 size.machine runaftermachine createfails is still present in 1.5.0. I reproducedOperation not supported by device. The smoke test's workaround stays.Validation
Run on Apple silicon, macOS 27.0, container 1.5.0, after rebasing onto current
main(Vitest 5):npm test: 303 passednpm run build,cargo fmt --check,cargo clippy -D warnings,cargo build: passcargo test: 117 passed, with 1 test ignored (the live smoke test)cargo test --test cli_compatibility live_smoke -- --ignored: passed against 1.5.0, and noacd-smoke-resources were left behindNot tested: the
system statusnot-running and unregistered paths. Testing them would mean stopping the local container service.