Make shapes constructed from bevy primitives dynamically resize to bounds - #55
Merged
Merged
Conversation
johanhelsing
force-pushed
the
bounded-shapes
branch
from
October 19, 2025 16:46
43dd7fa to
628f7c2
Compare
johanhelsing
force-pushed
the
bounded-shapes
branch
from
October 19, 2025 17:16
b7febad to
d3e8b39
Compare
Less boilerplate... and maybe it's nice to be backwards compatible.
johanhelsing
force-pushed
the
bounded-shapes
branch
from
October 19, 2025 17:21
d3e8b39 to
5e9f4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make shapes automatically resize to fit bounds.
Bounds is now basically the "size" of the the shape, perhaps it should be renamed...
If we chose to expose the
SmudPrimitivetrait it would be relatively trivial to implement conversions for your own shape "primitives". Not doing this in this PR, though.